Fix code color in html #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As LESS does not import CSS into scope where @import is called, and HTML ouput loads both default and night CSS, text color is incorrectly shown. To avoid that, embed the whole tomorrow-night CSS (BSD-3-Clause) https://raw.githubusercontent.com/highlightjs/highlight.js/master/src/styles/tomorrow-night.css
Member
|
Thanks! Shall we embed the other theme for consistency too? |
Contributor
Author
|
Unlike tomorrow-night, tomorrow is imported in two places - I think it's better to take more refactoring, such as using top-level class or including style based on the theme selection. However, I haven't digged into epub output, and JS part of it, which is required to make that change. If it works, then we may merge it and leave more refactoring to others :) |
Member
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927
As LESS does not import CSS into scope where @import is called, and HTML
ouput loads both default and night CSS, text color is incorrectly shown.
To avoid that, embed the whole tomorrow-night CSS (BSD-3-Clause)
https://raw.githubusercontent.com/highlightjs/highlight.js/master/src/styles/tomorrow-night.css
Note that this is copying BSD-3-Clause code into Apache 2. We anyway bundle it, so it is not adding new licensing issue, I believe.